Skip to content

Add Canada Ontario 2018-2022 orthoimagery #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

galen8183
Copy link
Contributor

Followup of #2657

Add GEospatial Ontario's (GEO's) 2018-2022 orthophotography WMS service from
https://geohub.lio.gov.on.ca/maps/lio::geospatial-ontario-imagery-data-services/about

Licensed under the OGL Ontario,
a license approved by the OSMF LWG

Regarding the licence attribution concerns in my previous PR (#2657 (comment)),
I'm really not sure what's wrong here... the source licence URL is/was already
linked in the attribution property, and like many other layers the license_url
links to the OSMF page on OGL variants. Please let me know if all of those
entries are incorrect, or if linking to a wiki page is in fact correct here.

Signed-off-by: Galen CC [email protected]

@andrewharvey andrewharvey force-pushed the canada-ontario-ortho branch from 6714e43 to 5555ccf Compare April 17, 2025 05:35
@andrewharvey
Copy link
Collaborator

andrewharvey commented Apr 17, 2025

The license_url doesn't have consistent use within existing sources and the current CONTRIBUTING guide and schema documentation aren't clear on what exactly this field should contain. In #790 (comment) I've proposed what I think we should use, but until it's documented I don't think we can expect too much of the field, and this PR uses it to point to documentation of the licensing permissions which is okay for the time being.

If we want the field to point to the publisher's statement on the data license, https://www.ontario.ca/page/copyright-information is probably the page to point to, then https://osmfoundation.org/wiki/OGL_Canada_and_local_variants would go under permission_url. But we'd want to get this schema change accepted and documented first (#790 (comment))

@andrewharvey
Copy link
Collaborator

What about the 2023-2027 layer? Should that be added to as best?

https://ws.geoservices.lrc.gov.on.ca/arcgis5/rest/services/AerialImagery/GEO_Imagery_Data_Service_2023to2027/ImageServer

@galen8183
Copy link
Contributor Author

galen8183 commented Apr 17, 2025

What about the 2023-2027 layer? Should that be added to as best?

It's documented as "coming soon", I'd be happy to add it now but perhaps it shouldn't be marked as best until it's complete. WDYT?

@andrewharvey
Copy link
Collaborator

It's documented as "coming soon", I'd be happy to add it now but perhaps it shouldn't be marked as best until it's complete. WDYT?

That's fine, can leave out for now and add later when it's ready I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants